feat(rpc): handle SA returning file#217
Merged
Merged
Conversation
092954f to
99b1195
Compare
99b1195 to
bb46f93
Compare
DayTF
approved these changes
May 27, 2026
forest-bot
added a commit
that referenced
this pull request
May 27, 2026
# [1.13.0](https://github.com/ForestAdmin/forestadmin-experimental/compare/datasource-rpc@1.12.3...datasource-rpc@1.13.0) (2026-05-27) ### Features * **rpc:** handle SA returning file ([#217](#217)) ([08cc659](08cc659))
forest-bot
added a commit
that referenced
this pull request
May 27, 2026
# [2.10.0](https://github.com/ForestAdmin/forestadmin-experimental/compare/rpc-agent@2.9.2...rpc-agent@2.10.0) (2026-05-27) ### Bug Fixes * **rpc datatource:** allow connect ruby as rpc ([#219](#219)) ([5034d74](5034d74)) ### Features * **rpc:** handle SA returning file ([#217](#217)) ([08cc659](08cc659))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file action result streaming support to RPC datasource and agent
RpcActionRoute.handleExecutein the rpc-agent now detectsFileaction results and streams the file body withContent-Disposition,X-Forest-Action-Type, andX-Forest-Action-File-Nameheaders; optionalresponseHeadersare forwarded viaX-Forest-Action-Response-Headers.RpcCollection.executein the datasource-rpc now bypasses superagent's JSON parsing, buffers the raw response, and inspectsX-Forest-Action-Typeto reconstruct aFileActionResult (with aReadablestream, mimeType, and decoded filename) or falls back to manual JSON parsing for other result types.Changes since #217 opened
RpcCollection.performActionmethod [6efcb19]Macroscope summarized bb46f93.